Merged
Conversation
…e runners for the matrix
Member
|
Some of the fixes you are introducing in #64 seem to be in this PR and it's making it hard for me to review this with a focus solely on the reader. Is there a chance you could split it just the reader changes here? |
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
IAlibay
approved these changes
Feb 16, 2026
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Just the one thing - I'm going to approve but please do merge the view->index_method change!
| @@ -213,69 +213,65 @@ def _get_unitcell( | |||
| def trajectory_from_multistate( | |||
Member
There was a problem hiding this comment.
This is the one that we don't formally use internally right?
Thanks for updating it!
Contributor
Author
There was a problem hiding this comment.
Yes, this is the one that we haven't been using yet.
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.